Skip to content

feat: Added DependencyVersionHelper for finding the latest release ve… #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

szymonsadowski3
Copy link
Contributor

Addresses 737-implement-dependency-version-helper

  • Adds a test helper for finding the latest release version for a given dependency.

@szymonsadowski3 szymonsadowski3 force-pushed the 737-implement-dependency-version-helper branch 2 times, most recently from 704c776 to e1c26f5 Compare April 28, 2023 08:56
Copy link
Contributor

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @szymonsadowski3! 🚀

Could you call your helper here?
You might want to add an @author to the class comment?

There was another integration test in sbm-shell but I can't recall.
If it fails next time we can use it there too.

I would have proposed to use OpenRewrite code to retrieve the version to be close to prod, but I like the simplicity of your helper ;)

@szymonsadowski3 szymonsadowski3 force-pushed the 737-implement-dependency-version-helper branch from b5f03b5 to 371d172 Compare May 24, 2023 20:26
@szymonsadowski3
Copy link
Contributor Author

Thank you for your contribution @szymonsadowski3! 🚀

Could you call your helper here? You might want to add an @author to the class comment?

There was another integration test in sbm-shell but I can't recall. If it fails next time we can use it there too.

I would have proposed to use OpenRewrite code to retrieve the version to be close to prod, but I like the simplicity of your helper ;)

I applied the suggestions. I searched for this another integration test where DependencyVersionHelper could be used, however, I could not find it

@szymonsadowski3 szymonsadowski3 requested a review from fabapp2 May 25, 2023 07:30
Copy link
Contributor

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀

@fabapp2 fabapp2 assigned fabapp2 and szymonsadowski3 and unassigned fabapp2 Jun 12, 2023
@fabapp2 fabapp2 added type: enhancement New feature or request type: test labels Jun 12, 2023
@fabapp2 fabapp2 added this to the v0.14.0 milestone Jun 12, 2023
@fabapp2
Copy link
Contributor

fabapp2 commented Jun 12, 2023

Thank you for your contribution @szymonsadowski3! 🚀
Could you call your helper here? You might want to add an @author to the class comment?
There was another integration test in sbm-shell but I can't recall. If it fails next time we can use it there too.
I would have proposed to use OpenRewrite code to retrieve the version to be close to prod, but I like the simplicity of your helper ;)

I applied the suggestions. I searched for this another integration test where DependencyVersionHelper could be used, however, I could not find it

Thanks, no problem. It will pop up ;)

@fabapp2 fabapp2 self-requested a review June 12, 2023 22:00
@fabapp2 fabapp2 merged commit 41edc6f into spring-projects-experimental:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request type: test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants