759 provide a maven pom cache for local maven repository #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Maven repo - Provides an initial (and incomplete) PomSerializer to serialize Pom model instances to a pom test file - Problem: The Pom contains information that can't be kept in a pom file and thus it can't always be de-/serialized which prevents using local Maven repo as cache store
fabapp2
force-pushed
the
759-provide-a-maven-pom-cache-for-local-maven-repository
branch
from
4fa87d8 to
a5958a8
Compare
|
Closing for now, see description |
fabapp2
deleted the
759-provide-a-maven-pom-cache-for-local-maven-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiment surfaced problems with the attempt to use local Maven repository dir as cache store for pom files downloaded by OpenRewrite's
MavenPomDownloader.The cache API used by
MavenPomDownloaderaccepts onlyPominstances.The
Pomclass represents the model and contains additional information (e.g.repository.password) which can't be seriaiized to a pom file adhering to the xsd.The PR brings an initial implementation of a
PomSerializerbut the above problem currently does not allow for a stable implementation.