Skip to content

Migrate JAX-RS default value annotation #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2023
Merged

Migrate JAX-RS default value annotation #604

merged 8 commits into from
Jan 25, 2023

Conversation

bottemav
Copy link
Contributor

Fixes #574

@fabapp2
Copy link
Contributor

fabapp2 commented Jan 4, 2023

Hi @bottemav,
thank you for your excellent contribution! 🚀
It's ready to be merged into the main branch.
Would you like to add your handle/name as @author?

@fabapp2 fabapp2 added type: enhancement New feature or request JEE/JAX-RS openrewrite Marks issues that might contain code worth contributing to OpenRewrite labels Jan 4, 2023
@fabapp2 fabapp2 added this to the v0.14.0 milestone Jan 4, 2023
@bottemav
Copy link
Contributor Author

@fabapp2 I added the author tag.

@fabapp2
Copy link
Contributor

fabapp2 commented Jan 25, 2023

@fabapp2 I added the author tag.

Thanks and sorry @bottemav

@fabapp2 fabapp2 merged commit 75beaa4 into spring-projects-experimental:main Jan 25, 2023
fabapp2 pushed a commit that referenced this pull request Jan 31, 2023
@bottemav @fabapp2
Migrate JAX-RS default value annotation (#604)
2713377 
* Add recipe CopyAnnotationAttribute which copies the value of an attribute from a source annotation to a target annotation
* Add recipe RemoveAnnotationIfAccompanied which removes an annotation if it is accompanied by another annotation
* Combine both recipes CopyAnnotationAttribute and RemoveAnnotationIfAccompanied in the recipe ReplaceRequestParameterProperties
* fix BootifyJaxRsAnnotationsRecipeTest
* add author tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabapp2 fabapp2 fabapp2 approved these changes

Assignees

@bottemav bottemav

Labels
JEE/JAX-RS openrewrite Marks issues that might contain code worth contributing to OpenRewrite type: enhancement New feature or request
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

JAX-RS: migrate DefaultValue annotation on request parameters
2 participants
@bottemav @fabapp2