Skip to content

Fix recipe names in Upgrade Report #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 15, 2022
Merged

Fix recipe names in Upgrade Report #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
dc1c80a
Updated version conditions for ConstructorBinding and Repository recipes
ashakirin Nov 14, 2022
9530a88
Fixed jakarta recipe name
ashakirin Nov 15, 2022
df8125c
Add request file
fabapp2 Nov 11, 2022
278b760
Add button to run all recipes and reactivated button to run single re…
fabapp2 Nov 11, 2022
cf875a7
Add button and change Controller to accept all applicable recipes
fabapp2 Nov 11, 2022
312f730
Move report generation into runner
fabapp2 Nov 13, 2022
897fd46
Hacked the Ajax into the rendered report
fabapp2 Nov 13, 2022
cb48dcf
WIP Made button load and send ajax request
fabapp2 Nov 14, 2022
a266a48
We remove the section when running recipe succeeds. (#551)
sanagaraj-pivotal Nov 14, 2022
37dee04
Moved add milestone repository for dependencies and plugins to dedica…
fabapp2 Nov 14, 2022
0c76b85
Moved dependency version updates to dedicated recipe
fabapp2 Nov 14, 2022
6e8149d
Moved dependency version updates to dedicated recipe
fabapp2 Nov 14, 2022
f4e1db9
Moved recipe for javax to jakarta package change to dedicated recipe
fabapp2 Nov 14, 2022
04e16e9
Moved recipe migration of spring.data properties to dedicated recipe
fabapp2 Nov 14, 2022
4305033
Moved recipe for PagingAndSoprtingRepository to dedicated recipe
fabapp2 Nov 14, 2022
f87cdaf
Moved new Spring Boot 3.0 upgrade recipes to dedicated dir
fabapp2 Nov 14, 2022
2c24e02
Renamed report recipe
fabapp2 Nov 14, 2022
1c4b87f
WIP
fabapp2 Nov 14, 2022
59f4a5d
We remove the section when running recipe succeeds. (#552)
sanagaraj-pivotal Nov 14, 2022
df8333a
Renamed Helper to something meaningful and fixed condition
fabapp2 Nov 14, 2022
68d6839
Updated version conditions for ConstructorBinding and Repository recipes
ashakirin Nov 14, 2022
02e4748
Fixed jakarta recipe name
ashakirin Nov 15, 2022
1f2a3a9
Merge branch 'spring-projects-experimental:main' into webapp-demo-sn-as
ashakirin Nov 15, 2022
694ed1e
Merge remote-tracking branch 'origin/webapp-demo-sn-as' into webapp-d…
ashakirin Nov 15, 2022
2becc00
Merge branch 'webapp-demo' into webapp-demo-sn-as
ashakirin Nov 15, 2022
4b37700
Merge remote-tracking branch 'origin/webapp-demo-sn-as' into webapp-d…
ashakirin Nov 15, 2022
8890b95
Closes #527. Fixed updated and deleted resources condition
ashakirin Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/sbm-core/src/main/java/org/springframework/sbm/engine/git/GitSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public void commitWhenGitAvailable(ProjectContext context, String appliedRecipeN
.map(r -> context.getProjectRootDirectory().relativize(Path.of(r)).toString())
.collect(Collectors.toList());

if (sbmApplicationProperties.isGitSupportEnabled() && !(modifiedResources.isEmpty() || deletedResources.isEmpty())) {
if (sbmApplicationProperties.isGitSupportEnabled() && (!modifiedResources.isEmpty() || !deletedResources.isEmpty())) {
File repoDir = context.getProjectRootDirectory().toFile();
if (repoExists(repoDir)) {
String commitMessage = "SBM: applied recipe '" + appliedRecipeName + "'";
Expand Down
2 changes: 1 addition & 1 deletion ...ot-upgrade/src/main/resources/recipes/27_30/report/sbu30-migrate-to-jakarta-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- name: sbu30-remove-construtor-binding
- name: sbu30-migrate-javax-to-jakarta
description: Spring boot 3.0 Upgrade - Migrate javax packages to new jakarta packages
condition:
type: org.springframework.sbm.common.migration.conditions.TrueCondition
Expand Down
2 changes: 1 addition & 1 deletion ...-upgrade/src/main/resources/recipes/27_30/report/sbu30-paging-and-sorting-repository.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- type: org.springframework.sbm.engine.recipe.OpenRewriteDeclarativeRecipeAdapter
condition:
type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
versionPattern: "3\\.0\\..*"
versionPattern: "2\\.7\\..*|3\\.0\\..*"
description: Add CrudRepository interface extension additionally to PagingAndSortingRepository
openRewriteRecipe: |-
type: specs.openrewrite.org/v1beta/recipe
Expand Down
4 changes: 2 additions & 2 deletions ...boot-upgrade/src/main/resources/recipes/27_30/report/sbu30-remove-construtor-binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
- type: org.springframework.sbm.engine.recipe.OpenRewriteDeclarativeRecipeAdapter
condition:
type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
versionPattern: "3\\.0\\..*"
versionPattern: "2\\.7\\..*|3\\.0\\..*"
description: Remove redundant @ConstructorBinding annotations when applicable
openRewriteRecipe: |-
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.spring.boot3.ImprovedConstructorBinding
displayName: Migrate additional Spring Boot properties to 2.7
displayName: Remove redundant @ConstructorBinding annotations
description: Remove redundant @ConstructorBinding annotations when applicable
recipeList:
- org.openrewrite.java.spring.boot3.RemoveConstructorBindingAnnotation
2 changes: 1 addition & 1 deletion ...cipes-boot-upgrade/src/main/resources/recipes/boot-2.7-3.0-dependency-version-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
# - type: org.springframework.sbm.engine.recipe.OpenRewriteDeclarativeRecipeAdapter
# condition:
# type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
# versionPattern: "3\\.0\\..*"
# versionPattern: "2\\.7\\..*|3\\.0\\..*"
# description: Remove redundant @ConstructorBinding annotations when applicable
# openRewriteRecipe: |-
# type: specs.openrewrite.org/v1beta/recipe
Expand Down