Test for getDependency variations #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabapp2
changed the title
- Fix getDeclaredDependencies()
- Missing test for getEffectiveDependencies - Missing test for getDeclaredDependencies - Add method to create ProjectContext from files
fabapp2
force-pushed
the
test-for-getDependency-variations
branch
from
31245fc to
b35853f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #492 surfaced some issues with the
getDependenciesvariations inOpenRewriteMavenBuildFile.This PR adds tests and fixes the surfaced issues with these methods.
Also, the
TestProjectContextnow offers a method to create theProjectContextfrom a given directory to ease testing of setups with multiple potentially larger files (as the ear example project).Additionally, the
PomBuilderhelper class was enhanced to allow building more complete pom files.@tan9 Could you try to see if things still/now work for you with this PR?