Remove standard maven-compiler plugin for applications with boot parent - gh-428 #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedmq
changed the title
fabapp2
added
type: enhancement
fabapp2
added
the
openrewrite
fabapp2
suggested changes
Nov 8, 2022
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...ents/sbm-core/src/main/java/org/springframework/sbm/build/migration/actions/SetProperty.java
Show resolved
Hide resolved
...ts/sbm-core/src/main/java/org/springframework/sbm/build/migration/recipe/AddMavenPlugin.java
Show resolved
Hide resolved
...ts/sbm-core/src/main/java/org/springframework/sbm/build/migration/recipe/AddMavenPlugin.java
Show resolved
Hide resolved
|
@fabapp2 - Do you want to have a look at the changes done? |
added 14 commits
December 14, 2022 15:37
- Fix typo - Generate maven properties - Change type to packaging - Add test
- Rename `Plugin.java` as `OpenRewriteMavenPlugin.java` - Extract interface from OpenRewriteMavenPlugin into `Plugin.java` - - An API interface for a potential gradle implementation in the future - Create new interface `Plugin#Configuration` and implementation - `OpenRewriteMavenPluginConfiguration`- Does not implement all methods in this commit - Refactor `Plugin#Execution` into `OpenRewriteMavenPlugin#OpenRewriteMavenPluginExecution` These changes are similar to the JavaSource rewrite approach.
setProperty() API no longer removes the maven property if the value supplied is null.
- Use Jackson XML pretty print to generate XML string for plugin configuration
- Use Plugin interface instead of OpenRewriteMavenPlugin implementation in dealing with objects
- Clean up BuildFile API - Use Java Refactoring to apply recipes via the plugin API - Disable multi-module tests as this needs core changes to POM file updates
fabapp2
approved these changes
Dec 15, 2022
| import org.springframework.sbm.engine.context.ProjectContext; | ||
| import org.springframework.sbm.engine.recipe.Condition; | ||
|
|
||
| public class SpringBootMavenCompilerExists implements Condition { |
There was a problem hiding this comment.
rename: SpringBootMavenCompilerpLuginExists
| @Override | ||
| public boolean evaluate(ProjectContext context) { | ||
|
|
||
| FileMatchingPatternExist fileMatchingPatternExist = new FileMatchingPatternExist(); |
There was a problem hiding this comment.
what about:
return context.getModules().stream()
.map(Module::getBuildFile())
.flatMap(b -> b.getPlugins().stream())
.anyMatch(p -> "maven-compiler-plugin".equals(p.getArtfactId()));| private static Stream<Arguments> input() { | ||
| return Stream.of( | ||
| Arguments.of( | ||
| """ |
| @Test | ||
| void removeRedundantMavenCompilerPlugin() { | ||
| String applicationDir = "simple-boot"; | ||
| RecipeIntegrationTestSupport.initializeProject(applicationDir) |
fabapp2
pushed a commit
that referenced
this pull request
Jan 31, 2023
…nt - gh-428 (#508) - Add New recipe and condition - Enhance PomBuilder.java - Use MavenBuildFileRefactoring to apply recipe, similar to JavaRefactoring - Refactor getPlugins() method in OpenRewriteMavenBuildFile - Extract Plugin interface and refactor Maven Plugin implementation - Create new interface `Plugin#Configuration` and implementation - Refactor `Plugin#Execution` into `OpenRewriteMavenPlugin#OpenRewriteMavenPluginExecution` - Add deleteProperty() API to BuildFile - setProperty() API no longer removes the maven property if the value supplied is null. - Add maven plugin configuration to PomBuilder - Use Jackson XML pretty print to generate XML string for plugin configuration - Add findPlugins API to BuildFile - Use Plugin interface instead of OpenRewriteMavenPlugin implementation in dealing with objects - Refactor Maven compiler plugin actions - Clean up BuildFile API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #428
RemoveRedundantMavenCompilerPluginProperties,RemoveRedundantMavenCompilerPlugin)remove-redundant-maven-compiler-plugin.yaml) and condition (SpringBootMavenCompilerExists)