Migrate Cassandra configuration to Spring Boot 3.0 in properties format

[kuldeepsidhu88]

Migrate Cassandra configuration to Spring Boot 3.0 in properties format
Fixes #442

[fabapp2]

Hi @kuldeepsidhu88

thank you for this contribution 🚀
I will review your PR asap, I was on vacation and am a bit behind.

[fabapp2]

Hi @kuldeepsidhu88

Nice, thank you 👍

Could you replace the Visitor with

          - org.openrewrite.properties.ChangePropertyKey:
              oldPropertyKey: spring.data.cassandra
              newPropertyKey: spring.cassandra   

which will do the same as the yaml but for properties files
Sorry, my bad as I didn't add this in the spec. 🙈

[fabapp2]

Hi @kuldeepsidhu88

Forgive me, I wanted to be nice and used the GitHub UI to resolve a merge conflict but broke the integration test leaving a ). 🙈
Shouldn't be hard to fix but I decided not to push anything to your PR.

[kuldeepsidhu88]

@fabapp2 Tried with the

Hi @kuldeepsidhu88

Nice, thank you 👍

Could you replace the Visitor with

          - org.openrewrite.properties.ChangePropertyKey:
              oldPropertyKey: spring.data.cassandra
              newPropertyKey: spring.cassandra   

which will do the same as the yaml but for properties files Sorry, my bad as I didn't add this in the spec. 🙈

I tried as above but test is failing and it does not remove the data property. Please let me know if I am missing something.
Noticed, this works fine if we provide the full property name.

[fabapp2]

@fabapp2 Tried with the

Hi @kuldeepsidhu88
Nice, thank you 👍
Could you replace the Visitor with

          - org.openrewrite.properties.ChangePropertyKey:
              oldPropertyKey: spring.data.cassandra
              newPropertyKey: spring.cassandra   

which will do the same as the yaml but for properties files Sorry, my bad as I didn't add this in the spec. 🙈

I tried as above but test is failing and it does not remove the data property. Please let me know if I am missing something. Noticed, this works fine if we provide the full property name.

Hm, I share your observation.
Maybe I had a bad day yesterday (well possible) or I did something differently.
Need to further investigate. Will ping you when I found the issue.

Update:
It should work. This test passes (as expected). Going for lunch now, need to debug this when I'm back... 🤔

public class ChangeKeyTest {
    @Test
    void test_renameMe() {
        String properties =
                "spring.data.cassandra=value";

        List<Properties.File> propertiesFiles = new PropertiesParser().parse(properties);

        RecipeRun run = new ChangePropertyKey("spring.data.cassandra", "spring.cassandra", null, null).run(
                propertiesFiles);
        assertThat(run.getResults().get(0).getAfter().printAll()).isEqualTo("spring.cassandra=value");
    }
}

"Noticed, this works fine if we provide the full property name." --> missed this sentence... wait

Update2: then the test fails. Will get back to you/this when I'm back from lunch...

[fabapp2]

Hi @kuldeepsidhu88

you know what... let's keep your visitor and get this into main?

[kuldeepsidhu88]

Hi @kuldeepsidhu88

you know what... let's keep your visitor and get this into main?

Sure, changed the PR status from Draft to Open. If no other changes required on this PR, feel free to merge it.

[fabapp2]

Thank you for your contribution @kuldeepsidhu88 🚀