Skip to content

Support for .mvn/maven.config #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanagaraj-pivotal
Copy link
Contributor

Closes #462

Copy link
Contributor

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanagaraj-pivotal 🚀

.flatMap(Collection::stream)
.filter(k -> envVarPattern.matcher(k).find())
.map(k -> k.replace("-D", ""))
.collect(Collectors.toMap(k -> k.split("=")[0], k -> k.split("=")[1]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a trim() so that the value of foo in foo = bar is 'bar' and not ' bar'

@fabapp2 fabapp2 added the type: enhancement New feature or request label Oct 14, 2022
@fabapp2 fabapp2 added this to the v0.13.0 milestone Oct 14, 2022
@fabapp2 fabapp2 changed the title 462 maven config resolution Support for .mvn/maven.config Oct 14, 2022
Copy link
Contributor

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sanagaraj-pivotal 🚀

@fabapp2 fabapp2 merged commit 8525fb8 into spring-projects-experimental:main Oct 14, 2022
@sanagaraj-pivotal sanagaraj-pivotal deleted the 462-maven-config-resolution branch October 15, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for .mvn/maven.config
2 participants