-
Notifications
You must be signed in to change notification settings - Fork 90
Support for .mvn/maven.config
#468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for .mvn/maven.config
#468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sanagaraj-pivotal 🚀
components/sbm-core/src/main/java/org/springframework/sbm/project/parser/MavenConfigParser.java
Outdated
Show resolved
Hide resolved
.flatMap(Collection::stream) | ||
.filter(k -> envVarPattern.matcher(k).find()) | ||
.map(k -> k.replace("-D", "")) | ||
.collect(Collectors.toMap(k -> k.split("=")[0], k -> k.split("=")[1])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a trim()
so that the value of foo
in foo = bar
is 'bar'
and not ' bar'
...onents/sbm-core/src/main/java/org/springframework/sbm/project/parser/MavenProjectParser.java
Outdated
Show resolved
Hide resolved
...onents/sbm-core/src/main/java/org/springframework/sbm/project/parser/MavenProjectParser.java
Show resolved
Hide resolved
…t put any files in the filesystem injectMavenConfigIntoSystemProperties() functions used to read files from physical filesystem causing a test failuers. now it is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @sanagaraj-pivotal 🚀
Closes #462