Skip to content

Use unified IsSpringBootProject condition #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8434328
Updated test container dependency
ashakirin Aug 18, 2022
c6624e4
Revert "Updated test container dependency"
ashakirin Aug 18, 2022
597e140
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Aug 22, 2022
48e5f8e
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Aug 24, 2022
ba6da28
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Aug 25, 2022
4720e24
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Aug 26, 2022
2f9c293
Merge branch 'spring-projects-experimental:main' into main
ashakirin Sep 5, 2022
216fcb4
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Sep 6, 2022
e820dc1
Merge branch 'spring-projects-experimental:main' into main
ashakirin Sep 12, 2022
911ec76
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Sep 15, 2022
c0b7c78
Merge branch 'spring-projects-experimental:main' into main
ashakirin Sep 19, 2022
543e9d8
Merge branch 'spring-projects-experimental:main' into main
ashakirin Sep 23, 2022
1a4298c
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Sep 26, 2022
26c6373
Merge branch 'spring-projects-experimental:main' into main
sanagaraj-pivotal Sep 28, 2022
3322f99
Replace IsAnyMatchingSpringBootVersion and IsMatchingSpringBootVersio…
sanagaraj-pivotal Sep 29, 2022
fd0f059
Replace IsAnyMatchingSpringBootVersion and IsMatchingSpringBootVersio…
sanagaraj-pivotal Sep 29, 2022
aebffce
Replace IsAnyMatchingSpringBootVersion and IsMatchingSpringBootVersio…
sanagaraj-pivotal Sep 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,37 +16,19 @@
package org.springframework.sbm.boot.upgrade_24_25.actions;

import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import org.springframework.sbm.boot.common.conditions.IsSpringBootProject;
import org.springframework.sbm.boot.upgrade.common.UpgradeReportUtil;
import org.springframework.sbm.boot.upgrade.common.conditions.IsMatchingSpringBootVersion;
import org.springframework.sbm.engine.recipe.AbstractAction;
import org.springframework.sbm.boot.UpgradeSectionBuilder;
import org.springframework.sbm.boot.asciidoctor.Section;
import org.springframework.sbm.boot.upgrade_24_25.report.*;
import org.springframework.sbm.engine.context.ProjectContext;
import org.springframework.sbm.java.api.JavaSource;
import org.springframework.sbm.project.resource.StringProjectResource;
import freemarker.template.Configuration;
import freemarker.template.Template;
import lombok.Getter;
import org.asciidoctor.Asciidoctor;
import org.asciidoctor.Options;
import org.asciidoctor.SafeMode;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.sbm.boot.UpgradeSectionBuilder;
import org.springframework.sbm.boot.asciidoctor.Section;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_Introduction;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_SchemaSqlAndDataSqlFiles;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_SeparateCredentials;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_SpringDataJpa;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_SqlScriptDataSourceInitialization;
import org.springframework.sbm.boot.upgrade_24_25.report.Boot_24_25_UpdateDependencies;
import org.springframework.sbm.engine.context.ProjectContext;
import org.springframework.sbm.engine.recipe.AbstractAction;
import org.springframework.sbm.java.api.JavaSource;
import org.springframework.sbm.project.resource.StringProjectResource;

import java.io.StringWriter;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.HashMap;
Expand Down Expand Up @@ -88,7 +70,10 @@ public void apply(ProjectContext projectContext) {
@Override
public boolean isApplicable(ProjectContext context) {
// Verify it's a 2.4.x Spring Boot project
return new IsMatchingSpringBootVersion("2.4.").evaluate(context);
IsSpringBootProject isSpringBootProject = new IsSpringBootProject();
isSpringBootProject.setVersionPattern("2\\.4\\..*");

return isSpringBootProject.evaluate(context);
}

@Getter
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
- name: boot-2.4-2.5-upgrade-report
description: Create Upgrade Report for a Spring Boot 2.4 Application
condition:
type: org.springframework.sbm.boot.upgrade.common.conditions.IsAnyMatchingSpringBootVersion
versionPatterns: 2.4.,2.5.
type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
versionPattern: "2\\.4\\..*|2\\.5\\..*"
actions:
- type: org.springframework.sbm.boot.upgrade_24_25.actions.Boot_24_25_UpgradeReportAction
description: Create Upgrade Report for a Spring Boot 2.4 Application
condition:
type: org.springframework.sbm.common.migration.conditions.TrueCondition
type: org.springframework.sbm.common.migration.conditions.TrueCondition
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- name: boot-2.7-3.0-upgrade-report
description: Create a report for Spring Boot Upgrade from 2.7.x to 3.0.0-M3
condition:
type: org.springframework.sbm.boot.upgrade.common.conditions.IsAnyMatchingSpringBootVersion
versionPatterns: 2.7.,3.0.
type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
versionPattern: "2\\.7\\..*|3\\.0\\..*"

actions:
- type: org.springframework.sbm.boot.upgrade_27_30.SpringBoot30UpgradeReport
Expand All @@ -17,4 +17,4 @@
- type: org.springframework.sbm.boot.upgrade_27_30.actions.Boot_27_30_AddLoggingDateFormat
description: "Sets logging date format to yyyy-MM-dd HH:mm:ss.SSS"
condition:
type: org.springframework.sbm.boot.upgrade_27_30.conditions.LoggingDateFormatCondition
type: org.springframework.sbm.boot.upgrade_27_30.conditions.LoggingDateFormatCondition
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
* Copyright 2021 - 2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.sbm.boot.common.conditions;

import org.intellij.lang.annotations.Language;
import org.junit.jupiter.api.Test;
import org.springframework.sbm.engine.context.ProjectContext;
import org.springframework.sbm.project.resource.TestProjectContext;

import static org.assertj.core.api.Assertions.assertThat;

class IsSpringBootProjectTest {
@Test
public void worksWithDependencyManagement() {

IsSpringBootProject target = new IsSpringBootProject();
target.setVersionPattern("2\\.7\\..*");

@Language("xml")
String pomXml = """
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.example</groupId>
<artifactId>demo</artifactId>
<version>0.0.1-SNAPSHOT</version>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>2.7.4</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
</project>
""";
ProjectContext context = TestProjectContext.buildProjectContext()
.withMavenRootBuildFileSource(pomXml)
.build();
boolean result = target.evaluate(context);

assertThat(result).isTrue();
}
}