Add Mule package type to getTopmostApplicationModules #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @cab105 ! 🚀 |
|
Dare I ask what the one comment is? |
fabapp2
suggested changes
Sep 18, 2022
components/sbm-core/src/main/java/org/springframework/sbm/build/api/ApplicationModules.java
Outdated
Show resolved
Hide resolved
fabapp2
approved these changes
Sep 18, 2022
Sorry, my bad. 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #373, I was able to figure out why my Mule project was not being picked up by Spring Boot Migrator. Turns out there's a check in the dependent call of
getTopmostApplicationModulesthat whitelists onlyjarbased applications. However, Mulesoft projects built with Anypoint Studio defaults to usingmule-application. Since this is the package type that I've been using for my mule migration projects, the code has consistently failed.This PR will whitelist this application type as the
migrate-mule-to-bootrecipe will convert the application type tojarafter it runs.