#329 compilable Boot Integration output #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components/sbm-support-boot/src/main/java/org/springframework/sbm/boot/properties/finder/SpringBootDefaultPropertiesFinder.java
fabapp2
reviewed
Aug 17, 2022
applications/spring-shell/src/test/resources/testcode/boot-migration-27-30/pom.xml
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...nts/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/sbm/build/migration/conditions/NoPluginRepositoryExistsCondition.java
Show resolved
Hide resolved
...ain/java/org/springframework/sbm/build/migration/conditions/NoRepositoryExistsCondition.java
Show resolved
Hide resolved
...test/java/org/springframework/sbm/build/migration/actions/AddPluginRepositoryActionTest.java
Show resolved
Hide resolved
fabapp2
reviewed
Aug 17, 2022
| import org.openrewrite.TreeVisitor; | ||
| import org.openrewrite.xml.AddToTagVisitor; | ||
| import org.openrewrite.xml.tree.Xml; | ||
| import org.springframework.sbm.build.api.RepositoryDefinition; |
There was a problem hiding this comment.
Make AddMavenPluginRepository and AddMavenRepository ready for contribution
fabapp2
reviewed
Aug 17, 2022
| @@ -22,7 +22,6 @@ | |||
| import org.openrewrite.Result; | |||
| import org.openrewrite.SourceFile; | |||
| import org.openrewrite.internal.lang.Nullable; | |||
| import org.openrewrite.java.JavaParser; | |||
fabapp2
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the output of integration test:
BootUpgrade_27_30_IntegrationTestis compilable. To achieve this we have made following changes:AddMavenPluginRepositorywhich adds plugin milestone repository to existing pomAddMavenPluginRepositoryis paired with a condition (NoPluginRepositoryExistsCondition) which adds plugin repository on when a plugin repo is not detected