Fixing failed unit tests which were trying to mock a static function #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabapp2
approved these changes
Aug 8, 2022
| @@ -47,7 +45,8 @@ void generateReportTest() throws IOException { | |||
| Path resultDir = RecipeIntegrationTestSupport.getResultDir(applicationDir); | |||
| String generatedReportContent = replaceDynamicPartsInReport(resultDir.resolve("Upgrade-Spring-Boot-2.4-to-2.5.html"), resultDir); | |||
|
|
|||
| String revision = GitSupport.getLatestCommit(resultDir.toAbsolutePath().toFile()).get().getHash(); | |||
| GitSupport gitSupport = new GitSupport(new SbmApplicationProperties()); | |||
There was a problem hiding this comment.
This will disable the gitSupport fwir as the flag will be initialized with false here. I guess that's ok or maybe better.
fabapp2
pushed a commit
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move
GitSupport. getLatestCommit()from member function to static function, some of the unit tests were mockinggetLatestCommit()since mockito will not mock static functions all of the tests were failing, hence revertinggetLatestCommit()from being static function to a member function.