#159 Added action for Johnzon upgrade for Spring boot migration 2.7 t…

[ravig-kant]

…o 3.x

[fabapp2]

Hi @ravig-kant
thanks a lot for you contribution, very much appreciated!
I had a few small comments, could you have a look?
Looking forward to merge your PR.

[BoykoAlex]

Shouldn't the recipe go in spring-boot-upgrade-30 project under the root? Or at lease some Rewrite dependent portion of the SBM recipe?

[ravig-kant]

Hi @fabapp2

I have a question about handling Johnzon dependencies for multi-module projects. In such cases should we not be updating the parent projects dependency management section? Also for spring-managed cases, we will have to add a dependency to the child module.

Hi @ravig-kant thanks a lot for you contribution, very much appreciated! I had a few small comments, could you have a look? Looking forward to merge your PR.

Thanks
Ravi

[fabapp2]

Shouldn't the recipe go in spring-boot-upgrade-30 project under the root? Or at lease some Rewrite dependent portion of the SBM recipe?

I'd say it's the right module for now. @sanagaraj-pivotal killed the spring-boot-upgrade-30´ module as this is basically sbm-openrewrite` where the resources were moved to. As the migration is done in plain SBM for now this module is ok imho.

[fabapp2]

Hi @fabapp2

I have a question about handling Johnzon dependencies for multi-module projects. In such cases should we not be updating the parent projects dependency management section? Also for spring-managed cases, we will have to add a dependency to the child module.

Hi @ravig-kant thanks a lot for you contribution, very much appreciated! I had a few small comments, could you have a look? Looking forward to merge your PR.

Thanks Ravi

Hi @ravig-kant

I am currently working on multi-module support.
Moving fixed set versions into a dependencyManagement section is something I could see as a separate recipe.
For this issue it should be enough to just set the version and classifier for all johnson dependencies found.

Making this multi-module aware could be achieved like so:

context.getApplicationModules().stream()
                .map(ApplicationModule::getBuildFile)
                .filter(b -> b.hasDeclaredDependencyMatchingRegex("..."))
                .forEach(this::doSomethingWithBuildFileContainingJohnzonDependency);

[fabapp2]

Hi @ravig-kant,
only a few tweaks are required to merge your PR to main:

• Remove the checks for imports, just having the dependency without a version (managed by Boot) should trigger the replacement with

<dependency>
            <groupId>org.apache.johnzon</groupId>
            <artifactId>johnzon-core</artifactId>
            <version>1.2.18</version>
	    <classifier>jakarta</classifier>
        </dependency>

• Add support for classifier in Dependency.fromCoordinates()
• Making the Action multi module aware by checking all ApplicationModules
• Adjust the test to expect jakarta as classifier in the added dependency

[fabapp2]

Thanks, @ravig-kant for your contribution 🎉