Allow MAVEN_HOME or M2_HOME for integration tests #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes an additional fix to ensure the version of spring-boot-starter-parent exists in Maven Central (3.x doesn't according to https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-parent) |
fabapp2
suggested changes
Jul 18, 2022
applications/spring-shell/src/test/java/org/springframework/sbm/IntegrationTestBaseClass.java
Show resolved
Hide resolved
...enrewrite/src/test/java/org/springframework/sbm/openrewrite/maven/BumpParentVersionTest.java
Outdated
Show resolved
Hide resolved
fabapp2
suggested changes
Jul 18, 2022
...enrewrite/src/test/java/org/springframework/sbm/openrewrite/maven/BumpParentVersionTest.java
Outdated
Show resolved
Hide resolved
|
That's my take. Okay let me take it out and verify. |
fabapp2
approved these changes
Jul 30, 2022
fabapp2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntegrationTestBaseClass is looking for the
MAVEN_HOMEenvironment variable, which only applies for Maven 1.x instead ofM2_HOMEwhich applies to Maven 2.x. This PR adds support for the second environment variable.