Skip to content

Config refactors for Spring 3.0 Milestone release #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 88 commits into from
Jul 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
e7fe085
Adding support for Transaction (closes #138)
sanagaraj-pivotal Jun 7, 2022
c59554c
Closes db insert component (#140)
sanagaraj-pivotal Jun 7, 2022
e59dd6e
Oracle DB Config support (#145)
sanagaraj-pivotal Jun 7, 2022
3e5a90f
Removing unused files in mule integration tests (#147)
sanagaraj-pivotal Jun 14, 2022
0a61b22
Bumped openrewrite to 7.22.0 (#174)
fabapp2 Jun 21, 2022
35868d6
Support for auto handling of SQL Injection in Mule closes #146
ashakirin Jul 7, 2022
a993ac5
Bump maven-invoker from 3.0.1 to 3.2.0 (#94)
dependabot[bot] Jul 7, 2022
10c307f
extra module for Spring Boot 3.0 upgrade OR Recipes and Visitors
fabapp2 Jun 15, 2022
dabd211
wip
fabapp2 Jun 15, 2022
cc5f981
wip
fabapp2 Jun 15, 2022
c5357a0
Beep. Beep. Beep
sanagaraj-pivotal Jun 16, 2022
64cea68
Fixed SpringBoot 3.0 Migration test
ashakirin Jun 20, 2022
8a11913
Refactor: adding repository and updating dependencies as separate tests
sanagaraj-pivotal Jun 20, 2022
3232bc2
Refactor: Moving AddMavenRepository to source folder
sanagaraj-pivotal Jun 21, 2022
7eb38ae
Refactor: Remove getApplicableTest() as its not needed
sanagaraj-pivotal Jun 21, 2022
ebd8bc1
Failing Test
sanagaraj-pivotal Jun 21, 2022
5730de5
Remove ConstructorBinding annotation: work in progress
ashakirin Jun 21, 2022
72c8540
Remove ConstructorBinding annotation: fixed test
ashakirin Jun 21, 2022
6a2d836
Updating test
sanagaraj-pivotal Jun 21, 2022
696eeef
Download artifcats instead of hardcoded paths
sanagaraj-pivotal Jun 21, 2022
4ebc4e5
Fixing Running of Junit 5 tests via maven
sanagaraj-pivotal Jun 22, 2022
39d7730
Remove exclusions and bringing in Junit5 as its not necessary
sanagaraj-pivotal Jun 22, 2022
a68be38
Updating maven-surefire to latest and greatest 3.0.0-M7
sanagaraj-pivotal Jun 22, 2022
6d7a40a
Removed unnecessary setters in recipe
ashakirin Jun 22, 2022
894d26d
Passing tests
sanagaraj-pivotal Jul 7, 2022
af8f965
Passing tests
sanagaraj-pivotal Jul 7, 2022
5750bf2
Passing tests
sanagaraj-pivotal Jul 7, 2022
a1cf782
Recipe moved
sanagaraj-pivotal Jul 7, 2022
9c0fc61
Added test for ChangePropertyKey
ashakirin Jul 7, 2022
4def981
Passing test
sanagaraj-pivotal Jul 7, 2022
d7d06e4
Passing test
sanagaraj-pivotal Jul 7, 2022
1adb185
Parameterising the test
sanagaraj-pivotal Jul 7, 2022
a380e02
refactor
sanagaraj-pivotal Jul 7, 2022
1e17206
Parameterising test
sanagaraj-pivotal Jul 7, 2022
a90dca5
Support Config Refactor: spring.data.elasticsearch.client.reactive.pa…
sanagaraj-pivotal Jul 8, 2022
4ede699
Support Config Refactor: spring.data.elasticsearch.client.reactive.so…
sanagaraj-pivotal Jul 8, 2022
c63351a
Added part of update properties tests
ashakirin Jul 8, 2022
1ef7d8e
Support Config Refactor YAML: spring.sql.init
sanagaraj-pivotal Jul 8, 2022
200379b
Support Config Refactor properties: spring.sql.init
sanagaraj-pivotal Jul 8, 2022
38a2f0e
Refactored properties update test
ashakirin Jul 8, 2022
aae727c
Use latest patched ChangePropertyKey Recipe
sanagaraj-pivotal Jul 8, 2022
ac1cce2
Refactor and failing test
sanagaraj-pivotal Jul 11, 2022
82cf7ef
Refactored updating properties into separate folder
ashakirin Jul 11, 2022
dce7032
Refactored base class for update configuration
ashakirin Jul 11, 2022
8bad13d
Passing test
sanagaraj-pivotal Jul 11, 2022
6fa8cc3
Fixing Management property removals
sanagaraj-pivotal Jul 11, 2022
01e5fc9
Passing test for active mq removal
sanagaraj-pivotal Jul 11, 2022
d127fa2
Added artemis configuration to remove
ashakirin Jul 11, 2022
48f6d2c
Passing test for misc removal
sanagaraj-pivotal Jul 11, 2022
b734303
Passing test for misc removal properties
sanagaraj-pivotal Jul 11, 2022
21238be
Run tests for all files specified in a folder
sanagaraj-pivotal Jul 11, 2022
76252bd
graphql
sanagaraj-pivotal Jul 11, 2022
2987b56
complete jta property removal
sanagaraj-pivotal Jul 11, 2022
dda7a44
Remove unused file
sanagaraj-pivotal Jul 11, 2022
e949651
Refactor remove unused method
sanagaraj-pivotal Jul 11, 2022
14da22d
extra module for Spring Boot 3.0 upgrade OR Recipes and Visitors
fabapp2 Jun 15, 2022
6109b95
wip
fabapp2 Jun 15, 2022
aaf10b2
wip
fabapp2 Jun 15, 2022
8a11b18
Beep. Beep. Beep
sanagaraj-pivotal Jun 16, 2022
4df989b
Fixed SpringBoot 3.0 Migration test
ashakirin Jun 20, 2022
10ae58e
Refactor: adding repository and updating dependencies as separate tests
sanagaraj-pivotal Jun 20, 2022
b2c7204
Refactor: Moving AddMavenRepository to source folder
sanagaraj-pivotal Jun 21, 2022
a429cab
Failing Test
sanagaraj-pivotal Jun 21, 2022
5303a66
Remove ConstructorBinding annotation: work in progress
ashakirin Jun 21, 2022
72fa71c
Remove ConstructorBinding annotation: fixed test
ashakirin Jun 21, 2022
b098403
Updating test
sanagaraj-pivotal Jun 21, 2022
1494ea3
Download artifcats instead of hardcoded paths
sanagaraj-pivotal Jun 21, 2022
e6f723b
Removed unnecessary setters in recipe
ashakirin Jun 22, 2022
c367ab7
Added test for ChangePropertyKey
ashakirin Jul 7, 2022
660d033
Passing test
sanagaraj-pivotal Jul 7, 2022
af0bae0
Parameterising the test
sanagaraj-pivotal Jul 7, 2022
2068666
Parameterising test
sanagaraj-pivotal Jul 7, 2022
53d674c
Support Config Refactor: spring.data.elasticsearch.client.reactive.pa…
sanagaraj-pivotal Jul 8, 2022
f47ffc7
Support Config Refactor: spring.data.elasticsearch.client.reactive.so…
sanagaraj-pivotal Jul 8, 2022
914b9b8
Added part of update properties tests
ashakirin Jul 8, 2022
69b3a12
Support Config Refactor YAML: spring.sql.init
sanagaraj-pivotal Jul 8, 2022
5acd2a6
Support Config Refactor properties: spring.sql.init
sanagaraj-pivotal Jul 8, 2022
e35c596
Refactored properties update test
ashakirin Jul 8, 2022
9c4dcfe
Use latest patched ChangePropertyKey Recipe
sanagaraj-pivotal Jul 8, 2022
862167c
Refactor and failing test
sanagaraj-pivotal Jul 11, 2022
f05b920
Refactored updating properties into separate folder
ashakirin Jul 11, 2022
b580738
Refactored base class for update configuration
ashakirin Jul 11, 2022
e72a3cc
Remove unused file
sanagaraj-pivotal Jul 11, 2022
518e01e
Converting from is a relationship to has a
sanagaraj-pivotal Jul 12, 2022
9a19a08
Take Recipe name from method param
sanagaraj-pivotal Jul 12, 2022
c041a65
Make methods of ConfigRecipeTestHelper are all static
sanagaraj-pivotal Jul 12, 2022
e29732b
Remove unused imports
sanagaraj-pivotal Jul 12, 2022
c7547cb
Merge branch 'spring-boot-upgrade-30' into spring-boot-upgrade-30
sanagaraj-pivotal Jul 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/mvn-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
java-version: '11'
distribution: 'adopt'
- name: Build with Maven
run: mvn --update-snapshots -DskipITs verify
run: mvn --update-snapshots -DtrimStackTrace=false -Dsurefire.useFile=false -DskipITs verify
19 changes: 0 additions & 19 deletions applications/spring-shell/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -208,25 +208,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>1.6</version>
<executions>
<execution>
<id>process-test-classes</id>
<phase>process-test-classes</phase>
<configuration>
<target>
<chmod file="target/test-classes/testcode/mule-app/prepare.sh" perm="755" />
</target>
</configuration>
<goals>
<goal>run</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,8 @@
package org.springframework.sbm;

import com.rabbitmq.client.Channel;
import org.jruby.RubyProcess;
import org.junit.jupiter.api.*;
import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
import org.junit.jupiter.api.condition.DisabledOnOs;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.sbm.mule.amqp.RabbitMqChannelBuilder;
Expand Down Expand Up @@ -83,13 +80,6 @@ public static void afterAll() {
}
}

@Test
@Tag("integration")
@DisabledIfSystemProperty(named= "os.arch", matches = "aarch64", disabledReason = "imbcom/mq image not supported with Apple Silicon")
void t1_testWebsphereMqMigration() throws JMSException, InterruptedException {
checkWmqIntegration(rabbitMqContainer.getNetwork());
}

@Test
@Tag("integration")
public void t0_springIntegrationWorks() throws IOException, TimeoutException, InterruptedException {
Expand All @@ -112,10 +102,15 @@ public void t0_springIntegrationWorks() throws IOException, TimeoutException, I
checkSendHttpMessage(container.getContainer().getMappedPort(9081));
checkInboundGatewayHttpMessage(container.getContainer().getMappedPort(9081));
checkRabbitMqIntegration(ampqChannel);
checkDbIntegration(container.getContainer().getMappedPort(9081));
}



@Test
@Tag("integration")
@DisabledIfSystemProperty(named= "os.arch", matches = "aarch64", disabledReason = "imbcom/mq image not supported with Apple Silicon")
void t1_testWebsphereMqMigration() throws JMSException, InterruptedException {
checkWmqIntegration(rabbitMqContainer.getNetwork());
}

private void checkRabbitMqIntegration(Channel amqpChannel)
throws IOException, InterruptedException {
Expand Down Expand Up @@ -160,6 +155,12 @@ private void checkWmqIntegration(Network rabbitMqNetwork) throws InterruptedExce
assertThat(latchResult).isTrue();
}

private void checkDbIntegration(int port) {
ResponseEntity<String> responseEntity = restTemplate.getForEntity("http://localhost:" + port + "/db", String.class);
assertThat(responseEntity.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(responseEntity.getBody()).contains("{\"ID\":1,\"USERNAME\":\"TestUser\",\"PASSWORD\":\"secret\"");
}

private void checkInboundGatewayHttpMessage(int port) {
ResponseEntity<String> responseEntity = restTemplate.getForEntity("http://localhost:" + port + "/helloworld", String.class);
assertThat(responseEntity.getStatusCode()).isEqualTo(HttpStatus.OK);
Expand Down

This file was deleted.

Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading