138 transactional #139
Merged
138 transactional #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabapp2
suggested changes
Jun 2, 2022
...-boot/src/main/java/org/springframework/sbm/mule/actions/javadsl/translators/DslSnippet.java
Show resolved
Hide resolved
...va/org/springframework/sbm/mule/actions/javadsl/translators/amqp/AmqConnectorTranslator.java
Show resolved
Hide resolved
| return new DslSnippet( | ||
| "/* TODO: LinkedMultiValueMap might not be apt, substitute with right input type*/\n" + | ||
| return DslSnippet.builder() | ||
| .renderedSnippet("/* TODO: LinkedMultiValueMap might not be apt, substitute with right input type*/\n" + |
There was a problem hiding this comment.
Leading space for comment for correct indent in method block?
.../main/java/org/springframework/sbm/mule/actions/javadsl/translators/db/SelectTranslator.java
Show resolved
Hide resolved
...ava/org/springframework/sbm/mule/actions/javadsl/translators/dwl/DwlTransformTranslator.java
Show resolved
Hide resolved
fabapp2
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue 138
Other Refactor:
DSLSnippet is converted from constructor based to builder based pattern.