Skip to content

3.0.0: Problems when upgrading spring petclinic to boot 3 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
fabapp2 opened this issue Aug 5, 2022 · 0 comments · Fixed by #311
Closed
1 task done

3.0.0: Problems when upgrading spring petclinic to boot 3 #294

fabapp2 opened this issue Aug 5, 2022 · 0 comments · Fixed by #311

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 5, 2022

Testing the upgrade recipe to Spring Boot 3.0.0-M3 with the spring petclinic surfaced problems.

Printout of applied actions

The console prints all actions of a recipe as applied, regardless of their condition, see

Problems with UpgradeParentPomVersion and jakarta classifier

The petclinic defines a ehcache dependency.
This dependency requires a jakarta classifier in 3.0.
Attempts to bump the parent version of the
pom.xml from petclinic from 2.7.1 to 3.0.0-M3 using UpgradeParentPomVersion failed. But the recipe was printed as successful applied.

Another problem was that the parent version wasn't updated (and exception swallowed) to 3.0.0-M3 without previously adding the jakarta classifier to the ehcache dependency.
But adding the jakarta classifier alone in 2.7 made the dependency resolution fail because the version managed by Spring Boot 2.7 does not exist with jakarta classifier.

Adding classifier and the version used in Boot 3.0.0 to the ehcache dependency in 2.7 and removing the version after bumping the parent to 3.0.0 solves this. This will probably be the case for more dependencies.

@pway99👆

  • [ ]
@fabapp2 fabapp2 changed the title 3.0.0: Run dependency upgrades before bumping parent version 3.0.0: Problems when upgrading spring petclinic to boot 3 Aug 5, 2022
@fabapp2 fabapp2 added this to the Spring Boot Upgrade 3.0 (M3) milestone Aug 5, 2022
fabapp2 pushed a commit that referenced this issue Aug 9, 2022
fabapp2 pushed a commit that referenced this issue Aug 11, 2022
fabapp2 pushed a commit that referenced this issue Aug 11, 2022
fabapp2 pushed a commit that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant