-
Notifications
You must be signed in to change notification settings - Fork 90
Resolving jars fails if pom file only exists in .m2/repository #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
in: sbm-support-rewrite
Issue is related to the sbm-support-rewrite compionent
type: bug
Something isn't working
type: test
Comments
fabapp2
added a commit
that referenced
this issue
Jul 12, 2022
fabapp2
added a commit
that referenced
this issue
Jul 12, 2022
fabapp2
added a commit
that referenced
this issue
Jul 12, 2022
fabapp2
added a commit
that referenced
this issue
Jul 12, 2022
* Fix MavenProjectParser to parse all resources * Provide HTTPClient with retry enabled and timeouts to RewriteMavenArtifactDownloader * Add maven caching to GitHub build action * Fix formatting * Disabled test until #195 is fixed
fabapp2
added a commit
that referenced
this issue
Jul 13, 2022
* Fix MavenProjectParser to parse all resources * Provide HTTPClient with retry enabled and timeouts to RewriteMavenArtifactDownloader * Add maven caching to GitHub build action * Fix formatting * Disabled test until #195 is fixed
fabapp2
added a commit
that referenced
this issue
Jul 14, 2022
* Fix MavenProjectParser to parse all resources * Provide HTTPClient with retry enabled and timeouts to RewriteMavenArtifactDownloader * Add maven caching to GitHub build action * Fix formatting * Disabled test until #195 is fixed
fabapp2
added a commit
that referenced
this issue
Jul 14, 2022
* Fix MavenProjectParser to parse all resources * Provide HTTPClient with retry enabled and timeouts to RewriteMavenArtifactDownloader * Add maven caching to GitHub build action * Fix formatting * Disabled test until #195 is fixed
. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: sbm-support-rewrite
Issue is related to the sbm-support-rewrite compionent
type: bug
Something isn't working
type: test
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
In some situations a
jar
declared as dependency in apom
is not checked to exist but expected to be present when the.pom
exists in.m2/repository
.Dependency resolution then fails if only the
.pom
exists but not the.jar
.To Reproduce
MavenPomDownloader
configured to useInMemoryMavenPomCache
MavenArtifactDownloader
configured to use LocalMavenArtifactCache~/.m2/repository
, let’s say~/.m2/repository/org/slf4j/slf4j-api/1.7.30
is empty1.1. pom gets downloaded in memory ✅
1.2. jar gets downloaded to
~/.m2/repository/org/slf4j/slf4j-api/1.7.30
✅2.1 Nothing gets downloaded, jar is taken from
~/.m2/repository/org/slf4j/slf4j-api/1.7.30
✅3.1. The pom is taken from the dependency dir
~/.m2/repository/org/slf4j/slf4j-api/1.7.30/slf4j-api-1.7.30.pom
3.2. The jar is expected to be in this dir, BUT IT’S NOT ❎
Expected behavior
Either
MavenPomDownloader
should only check it'sInMemoryMavenPomCache
Or
LocalMavenArtifactCache
should check if the jar actually exists and download it to.m2/repository
if not but not expect it to exist because the pom exists in.m2
.Stacktrace
Additional context
This test can be used, and by changing what's in (e.g.
/Users/fkrueger/.m2/repository/org/slf4j/slf4j-api/1.7.30
) the described behavior can be triggeredThe text was updated successfully, but these errors were encountered: