Skip to content

Fix Conditions for Spring Boot 2.4 to 2.5 Upgrade recipes #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabapp2 opened this issue May 25, 2022 · 1 comment · Fixed by #135
Closed

Fix Conditions for Spring Boot 2.4 to 2.5 Upgrade recipes #133

fabapp2 opened this issue May 25, 2022 · 1 comment · Fixed by #135
Labels
type: bug Something isn't working
Milestone

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented May 25, 2022

Thanks for reporting @Turbots!

Describe the bug
Some recipes of the Spring Boot 2.4 to 2.5 Upgrade functionality are always shown as applicable.

To Reproduce

  1. Run the demo-upgrade-spring-boot-report demo and upgrade the demo app to 2.5.x
  2. Then scan the application again
  3. The applied recipes for 2.4.x Spring Boot is still shown as applicable

Expected behavior
The 2.4 upgrade-related recipes should not be shown for any Spring Boot application with a version different from 2.4.x.

Additional context
For multiple of these recipes the condition is set to org.springframework.sbm.common.migration.conditions.TrueCondition which makes SBM always show it as applicable.

@fabapp2 fabapp2 added the type: bug Something isn't working label May 25, 2022
@fabapp2
Copy link
Contributor Author

fabapp2 commented May 25, 2022

If boot-2.4-2.5-sql-init-properties gets applied after boot-2.4-2.5-datasource-initializer the properties used in the spring.datasource.schema-... properties added with DataSourceInitializerConfiguration get changed. This is wrong. Either provide order appropriately and add condition check to avoid showing boot-2.4-2.5-sql-init-properties as applicable after boot-2.4-2.5-datasource-initializer hjas been applied, or change property names in DataSourceInitializerConfiguration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
1 participant