Add test for local maven repo set in settings.xml

Author: fabapp2

components/sbm-core/src/main/java/org/springframework/sbm/build/impl/RewriteMavenParser.java

@@ -75,8 +75,7 @@ public List<Xml.Document> parse(String... sources) {
     @Override
     public List<Xml.Document> parse(ExecutionContext ctx, String... sources) {
         mavenSettingsInitializer.initializeMavenSettings(ctx);
-        parser.parse(ctx, sources);
-        return Parser.super.parse(ctx, sources);
+        return parser.parse(ctx, sources);
     }
 
     /**

components/sbm-core/src/test/java/org/springframework/sbm/build/impl/MavenSettingsInitializerTest.java

@@ -25,7 +25,6 @@
 import java.nio.file.Path;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.jupiter.api.Assertions.*;
 
 /**
  * @author Fabian Krüger
@@ -72,14 +71,22 @@ void mavenParserMustAdhereToSettingsXmlTest() throws URISyntaxException {
         MavenRepository localRepository = mavenExecutionContextView.getLocalRepository();
         assertThat(localRepository.isSnapshots()).isTrue();
 
-//        assertThat(localRepository.getUri()).isEqualTo("file:" + fakedUserHome + "/.m2/repository/");
-        assertThat(localRepository.getUri()).isEqualTo(MavenRepository.MAVEN_LOCAL_DEFAULT.getUri());
+        String tmpDir = removeTrailingSlash(System.getProperty("java.io.tmpdir"));
+        String customLocalRepository = new URI("file://" + tmpDir).toString();
+        assertThat(removeTrailingSlash(localRepository.getUri())).isEqualTo(customLocalRepository);
         assertThat(localRepository.isSnapshots()).isTrue();
         assertThat(localRepository.isKnownToExist()).isTrue();
         assertThat(localRepository.getUsername()).isNull();
         assertThat(localRepository.getPassword()).isNull();
     }
 
+    String removeTrailingSlash(String string) {
+        if(string.endsWith("/")){
+            return string.substring(0, string.length()-1);
+        }
+        return string;
+    }
+
     @AfterEach
     public void reset() {
         // reset

components/sbm-core/src/test/java/org/springframework/sbm/build/impl/RewriteMavenParserTest.java

@@ -49,9 +49,7 @@ void customExecutionContextGiven() {
         String pom = PomBuilder.buildPom("com.example:project:1.0").build();
         ExecutionContext ctx = new RewriteExecutionContext();
         sut.parse(ctx, pom);
-        // first time when initializing the parser
-        // second time in the parse method to guarantee ExecutionContext is enriched with MavenSettings
-        verify(mavenSettingsInitializer, times(2)).initializeMavenSettings(ctx);
+        verify(mavenSettingsInitializer).initializeMavenSettings(ctx);
     }
 
 }

components/sbm-core/testcode/project-with-maven-settings/.gitignore

@@ -0,0 +1,3 @@
+.m2/repository/
+.config
+.rewrite

components/sbm-core/testcode/project-with-maven-settings/user-home/.m2/settings.xml

@@ -2,9 +2,12 @@
 <settings xsi:schemaLocation='http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd'
           xmlns='http://maven.apache.org/SETTINGS/1.0.0' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'>
 
+    <localRepository>${java.io.tmpdir}</localRepository>
     <profiles>
         <profile>
-            <activeByDefault>true</activeByDefault>
+            <activation>
+                <activeByDefault>true</activeByDefault>
+            </activation>
             <repositories>
                 <repository>
                     <snapshots>