Skip to content

Commit d92c71c

Browse files
fabapp2fabapp2
committed
Render link to GitHub issues as external link
1 parent 904df63 commit d92c71c

9 files changed

+14
-15
lines changed

‎components/sbm-recipes-boot-upgrade/src/main/java/org/springframework/sbm/boot/upgrade_27_30/report/SpringBootUpgradeReportSection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ private void renderLineBreak(StringBuilder sb) {
209209

210210
private void renderGitHubInfo(StringBuilder sb) {
211211
if(gitHubIssue != null) {
212-
sb.append("Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/").append(gitHubIssue).append("[#").append(gitHubIssue).append("]");
212+
sb.append("Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/").append(gitHubIssue).append("[#").append(gitHubIssue).append("^, role=\"ext-link\"]");
213213
}
214214
if(contributors != null && gitHubIssue != null) {
215215
sb.append(", ");

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/ActuatorEndpointsSanitizationReportSectionTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ void shouldRender() {
5959
.fromProjectContext(context)
6060
.shouldRenderAs("""
6161
=== Actuator Endpoints Sanitization
62-
63-
Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
62+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/445[#445^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
6463
6564
==== What Changed
6665
Since, the `/env` and `/configprops` endpoints can contains sensitive values, all values are always masked by default.

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/BannerSupportReportSectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public void rendersBannerSupportInformation() {
3838
.shouldRenderAs(
3939
"""
4040
=== Banner support
41-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/150[#150], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"], https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
41+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/150[#150^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"], https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
4242
4343
==== What Changed
4444
Support for image-based application banners has been removed. banner.gif, banner.jpg, and banner.png

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/ChangesToDataPropertiesReportSectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ void changesToDataPropertiesSection_renders() {
4343
.shouldRenderAs(
4444
"""
4545
=== Changes to Data Properties
46-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/441[#441], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
46+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/441[#441^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
4747
4848
==== What Changed
4949
The data prefix has been reserved for Spring Data and any properties under the `spring.data` prefix imply that Spring

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/CommonsMultipartResolverHelperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public CommonsMultipartResolver commonsMultipartResolver() {
5555
.shouldRenderAs(
5656
"""
5757
=== Commons Multipart Upload
58-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/541[#541], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
58+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/541[#541^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
5959
6060
==== What Changed
6161
Support for Spring Framework’s `CommonsMultipartResolver` has been removed following its removal in Spring Framework 6
@@ -121,7 +121,7 @@ public CommonsMultipartResolver songMultiPartUploader() {
121121
.shouldRenderAs(
122122
"""
123123
=== Commons Multipart Upload
124-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/541[#541], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
124+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/541[#541^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
125125
126126
==== What Changed
127127
Support for Spring Framework’s `CommonsMultipartResolver` has been removed following its removal in Spring Framework 6

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/ConstructorBindingReportSectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public String getFrom() {
7272
.shouldRenderAs(
7373
"""
7474
=== Constructor Binding
75-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/166[#166], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
75+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/166[#166^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
7676
7777
==== What Changed
7878
When using constructor bound @ConfigurationProperties the @ConstructorBinding annotation

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/LoggingDateFormatReportSectionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void shouldRenderSectionWhenNoPropertiesExist() {
4141
.shouldRenderAs(
4242
"""
4343
=== Logging Date Format
44-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/489[#489], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
44+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/489[#489^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
4545
4646
==== What Changed
4747
The default format for the date and time component of log messages for Logback and Log4j2 has changed to
@@ -73,7 +73,7 @@ void shouldRenderSectionWhenPropertyNotDefined() {
7373
.shouldRenderAs(
7474
"""
7575
=== Logging Date Format
76-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/489[#489], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
76+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/489[#489^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
7777
7878
==== What Changed
7979
The default format for the date and time component of log messages for Logback and Log4j2 has changed to

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/PagingAndSortingHelperTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class A {}
5858
.shouldRenderAs(
5959
"""
6060
=== Paging and sorting repository
61-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
61+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
6262
6363
==== What Changed
6464
Sorting repositories no longer extend their respective CRUD repository.
@@ -119,7 +119,7 @@ public class A {}
119119
.shouldRenderAs(
120120
"""
121121
=== Paging and sorting repository
122-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
122+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
123123
124124
==== What Changed
125125
Sorting repositories no longer extend their respective CRUD repository.
@@ -180,7 +180,7 @@ public class A {}
180180
.shouldRenderAs(
181181
"""
182182
=== Paging and sorting repository
183-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
183+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
184184
185185
==== What Changed
186186
Sorting repositories no longer extend their respective CRUD repository.
@@ -268,7 +268,7 @@ public class A {}
268268
.shouldRenderAs(
269269
"""
270270
=== Paging and sorting repository
271-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
271+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/518[#518^, role="ext-link"], Contributors: https://github.com/sanagaraj-pivotal[@sanagaraj-pivotal^, role="ext-link"]
272272
273273
==== What Changed
274274
Sorting repositories no longer extend their respective CRUD repository.

‎components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/SpringMVCAndWebFluxUrlMatchingChangesReportSectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class AnotherClass {};
6666
String expectedOutput =
6767
"""
6868
=== Spring MVC and WebFlux URL matching changes
69-
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/522[#522], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
69+
Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/522[#522^, role="ext-link"], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
7070
7171
==== What Changed
7272
As of Spring Framework 6.0, the trailing slash matching configuration option has been deprecated and its default value set to `false`.

0 commit comments

Comments
 (0)