Skip to content

Fix first_image not resolving correctly in subdirectories #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 8, 2022
Merged

Fix first_image not resolving correctly in subdirectories #61

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6dc1d0b
Add fix for first image in subdirectories
ItayZiv Mar 2, 2022
431c546
Fix split and run black
ItayZiv Mar 3, 2022
5c75ce7
Change fix to use page_url directly
ItayZiv Mar 3, 2022
591ced9
Change tests to use a url containing a path and move rel paths near f…
ItayZiv Mar 3, 2022
1526f88
Run black
ItayZiv Mar 3, 2022
19ed6e0
Fix local images in conf.py and add test
ItayZiv Mar 5, 2022
969c58a
Add workaround to keep ogp_image relative root
TheTripleV Mar 8, 2022
9b0b276
Remove unneeded condition in if
ItayZiv Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sphinxext/opengraph/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ def get_tags(
image_url_parsed = urlparse(image_url)
if not image_url_parsed.scheme:
# Relative image path detected. Make absolute.
image_url = urljoin(config["ogp_site_url"], image_url_parsed.path)
image_url = urljoin(
config["ogp_site_url"], image_url_parsed.path.split("../")[-1]
)
tags["og:image"] = image_url

# Add image alt text (either provided by config or from site_name)
Expand Down