Skip to content

Add documentation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 22, 2021
Merged

Add documentation #31

merged 11 commits into from
Jan 22, 2021

Conversation

Daltz333
Copy link
Collaborator

No description provided.

@Daltz333
Copy link
Collaborator Author

Not sure why it's failing, it works locally. Any ideas @TheTripleV

@modelmat
Copy link

Not sure why it's failing, it works locally. Any ideas

You don't install the extension in the CI.

See
https://github.com/Daltz333/sphinxext-opengraph/blob/efda5e6776c106d81e54596a22facdcc856753a4/.github/workflows/workflow.yml#L43-L45 for when it's done for other tests.

It will work locally because you have the extension installed locally already.

@Daltz333
Copy link
Collaborator Author

@modelmat
Copy link

Open graph is not in those requirements.txt files.

@Daltz333
Copy link
Collaborator Author

It is, it's ../

@ItayZiv
Copy link
Collaborator

ItayZiv commented Dec 22, 2020

You need to uncomment these lines in conf.py

# import os
# import sys
# sys.path.insert(0, os.path.abspath('.'))

and change the last line to

sys.path.insert(0, os.path.abspath('../..'))

(This is because you are installing the package from a nonstandard directory, so you need to add that directory to the sys.path)

@TheTripleV
Copy link
Collaborator

Can you have the ci upload the built html as an artifact?

@Daltz333 Daltz333 merged commit 4fa7c2d into sphinx-doc:master Jan 22, 2021
@Daltz333 Daltz333 deleted the opengraph-docs branch January 22, 2021 06:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants