Complete Type Hints and Add support for custom tags #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sphinx's included coverage extension was used as reference
|
Will og:ignore_canonical allow the frc-docs to onebox on discourse? |
|
Yes, it should. I haven't found it documented anywhere but it's in the Onebox source code. |
|
I forgot to fully do typing when originally doing stuff, also probably worth having a config options for custom tags, not a default (not relevant for everyone using this) |
ItayZiv
reviewed
Jul 10, 2020
|
Based on Discord discussion:
Ex. ogp_custom_meta_tags = [
'<meta property="og:ignore_canonical" content="true" />',
] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hints
Type hints were only partially filled in. This completes them. This allows intellisense to work.
Custom tag support
Discourse's Onebox invented their own og tag, "og:ignore_canonical".