-
-
Notifications
You must be signed in to change notification settings - Fork 30
make matplotlib optional #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will this break any existing users (aka is it opt-out instead of opt-in)? |
Well the issue from #100 was asking for it to be opt-in, since it was added recently, right? |
If matplotlib is installed, it's opt out. If matplotlib isn't installed, it doesn't run. So it should keep existing behavior. |
So this should only break CI environments for users. That still is pretty bad, but I'm not sure there is a better solution. |
No it shouldn't break ci for anyone. If matplotlib isn't installed it just turns off image generation |
I wish there was a behavior where we automatically instead matplotlib and the user can explicitly choose not to instead it, instead of the opposite. |
I don't think that's possible |
closes #100