Enhancements made for use with the Wombat data logger

[dajtxx]

Fixed a couple of memory bugs related to URC processing.
Enhanced support for MQTT.
Added support for FTP.
Added URC string constants.
Added getFileBlock method.

[PaulZC]

Hi David (@dajtxx ),

Sincere thanks for this. Just working my way through it now. (It would have really helped if you could have broken this up into separate commits!)

More later...

Best wishes,
Paul

[dajtxx]

There are a few more changes coming. 1. Remove the F macro from printf method calls in getFileBlock because it doesn't work. I hacked my WString.h file a long time ago and forgot about it. 2. Some more FTP related methods. Regards, David.

[PaulZC]

Looks great - thanks!
There are some small tweaks to be made.
Please have a look at the backward compatibility concerns. I'm worried most about the int to SARA_R5_mqtt_command_opcode_t change. I'll have to merge your changes to test it.

[PaulZC]

Hi David,
Many thanks for the changes.
I'll run the workflow on this now, just in case it finds something - it compiles a library example on multiple platforms.
Please let me know when you've finished making changes and I will merge and test.
Best wishes,
Paul

[dajtxx]

Thanks Paul. We have a few more FTP methods coming but they're not related to these ones, so a new pull request should be ok for them. I don't plan on changing anything more in this pull request.

[PaulZC]

Thanks David.
The workflow is failing on everything except ESP32C3. Weird... Probably a small change which has messed things up. Investigating...

[dajtxx]

Not a great result.

I'm having a look too. There is at least one place I missed the change from the command enum type back to an int, and a lot of String problems.

[PaulZC]

Thanks David.

If you're OK picking your way through the workflow checks, I'll just leave it with you.

ESP32 only found one error - trying to sscanf into your enum (instead of an int).
Several platforms seem to have an issue with String isEmpty.

Let me know if you need me to help resolve anything and/or re-run the workflow.

Best,
Paul

[dajtxx]

Hi Paul, can you please run this commit through the tests?

I was about the change the workflow to allow workflow_dispatch so I could run them on the fork but I think that will get pushed through to you so I stopped.

[PaulZC]

Hi David,

Sure. I just added workflow_dispatch to main. Please feel free to copy and push the change from there.

[dajtxx]

Thanks, the workflow passed on my fork.

[PaulZC]

Thanks David - all looks good.
I'm going to merge this into release_candidate and give it a quick check over.

[PaulZC]

I'm seeing a clean compile with Michael Ammann @mazgch 's HPG code - which uses setMQTTclientId internally. That's good enough for me!
Merging into main and will release shortly...
Thanks again David,
Paul