allow customisation of beginSerial #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mazgch
commented
May 18, 2022
mazgch
commented
- make beginSerial virtual so that we can override and assign custom pins and configuration
- end the serial port before new begin to avoid crash on ESP32 when data is received while begin is called. I suspect the CRASH is due to the isr still being active if end is not called while begin is reconfiguring the hardware
- make beginSerial virtual so that we can override and assign custom pins and configuration - end the serial port before new begin to avoid crash on ESP32 when data is received while begin is called
|
Thank you Michael - merging for testing |
|
Tested OK on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.