-
Notifications
You must be signed in to change notification settings - Fork 106
getUnixEpoch() method added #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @UT2UH , |
Great contribution @UT2UH! I've been meaning to add Unix epoch time functionality to the u-blox library for a while now. Currently, the Additionally, were we to enforce these validity checks, I believe we'd also need to check Cheers, |
Another small suggestion is that if we'd like to have consistency across all SparkFun RTC libraries, the commonly used function name for reading epoch time is is |
Hi @UT2UH , I must admit, I think it might be a good idea to remove the confirmedTime check from getUnixEpoch. That way users of modules with older firmware will be able to use the function. Not all modules /protocol versions support time validity. What are your thoughts please? @adamgarbo: I'm not worried about the function name. get UnixEpoch makes it clear it is the 1970 Epoch, not any of the other variants. But thanks for the reminder! Best wishes, |
Hi there! |
Would it also be possible to modify
This would allow it to be called by users who aren't interested in microseconds. Cheers, |
Hi @adamgarbo, |
Thanks, @UT2UH! |
Unix Epoch time returned as uint32_t to cast to user provided time library 'time_t' type.