Skip to content

Release candidate #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Conversation

mazgch
Copy link
Contributor

@mazgch mazgch commented Feb 14, 2022

Few imporvements:

  • New Feature: outputPort allow logging of any incoming data (e.g to a SDCard File)
  • BugFix: set the UBLOX_CFG_SPARTN_USE_SOURCE to LBAND (= PMP message) in the example
  • BugFix: make PMP message as valid so that later the callback is triggered.

Potential Issue: The PMP current approach could trigger an issue if PMP messages arrive faster than the callbacks are triggered. In such a case the captured data is overridden by the next message before it is forwarded to the ZED. This is rather unlikely as PMP arrive slower than every second.

The failure I saw in GNSS configuration with keys I saw was caused by the "......" in the second key. Maybe we can make it clear with a better message if that fails that customers have to touch the secrets file. or Secrets file could fail compiling.

@PaulZC PaulZC merged commit 2e6f6ce into sparkfun:release_candidate Feb 14, 2022
@PaulZC
Copy link
Collaborator

PaulZC commented Feb 14, 2022

Thank you Michael (@mazgch ),

Re. the "Potential Issue": I agree. For the other "auto" messages, the callback copy is only overwritten if the callback copy has been processed. E.g.:

&& (packetUBXNAVAOPSTATUS->automaticFlags.flags.bits.callbackCopyValid == false)) // AND the data is stale

I can either leave the code as it is now, the callback will always receive the newest PMP data. New data always overwrites old.

Or, I can change it so that the callback data is preserved until the callback has been called. New data is discarded until the old data has been processed.

Please let me know which you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants