Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few imporvements:
Potential Issue: The PMP current approach could trigger an issue if PMP messages arrive faster than the callbacks are triggered. In such a case the captured data is overridden by the next message before it is forwarded to the ZED. This is rather unlikely as PMP arrive slower than every second.
The failure I saw in GNSS configuration with keys I saw was caused by the "......" in the second key. Maybe we can make it clear with a better message if that fails that customers have to touch the secrets file. or Secrets file could fail compiling.