Skip to content

sendI2cCommand writes the wrong character if lenght =n*i2cTransactionSize + 1 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Valrakk opened this issue Aug 26, 2021 · 3 comments

Comments

@Valrakk
Copy link

Valrakk commented Aug 26, 2021

The line

Seems to be a intended to work with *outgoingUBX->payload += len; which moves the payload pointer, but is now commented. I think it should be _i2cPort->write(outgoingUBX->payload[startSpot], 1);

@PaulZC
Copy link
Collaborator

PaulZC commented Aug 27, 2021

Hi @Valrakk ,

Wow. Great find! That bug has been in there for years! (Back even before I started working on the library!)

I'm curious... How did you find it? Was there a message being Not-ACKnowledged?

Thanks again - I will fix this shortly,
Paul

PaulZC added a commit that referenced this issue Aug 27, 2021
PaulZC added a commit that referenced this issue Aug 27, 2021
@PaulZC
Copy link
Collaborator

PaulZC commented Aug 27, 2021

Corrected in v2.0.14 - thanks again!

@PaulZC PaulZC closed this as completed Aug 27, 2021
@Valrakk
Copy link
Author

Valrakk commented Aug 27, 2021

I was looking at the code to make a small driver to test a MAX-M8C module in a STM32 mcu, using i2c, and that line just caught my attention.

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants