This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-writes how we look for responses from sendCommand(). Instead of assume an ACK is valid we explicitly look for the correct ACK depending on the type of packet being sent. From the UBX datasheet:
For packets intended to re-configure the Ublox module, we look for an ACK but this is split into two cases:
For packets intended to merely get data from the Ublox module (for example a PVT packet), we look for packetCfg to be filled but there will be no ACK. We use waitForNoACKResponse. For NoAck responses, we still verify that the CLS/ID of the incoming packet (think PVT) match what we asked for.
This PR generally improves the stability of the library. There are still plenty of ways to break it but it's working much better.
There were a few small changes:
Known issues: