Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

NAV-PVT velocity parameters parsed. #146

Merged
merged 3 commits into from
Nov 4, 2020
Merged

NAV-PVT velocity parameters parsed. #146

merged 3 commits into from
Nov 4, 2020

Conversation

balamuruganky
Copy link
Contributor

Please consider to merge this request. NAV-PVT velocity parameters are parsed.

@nseidle
Copy link
Member

nseidle commented Nov 3, 2020

Thank you! Looks pretty good. Please consider adding the new functions to the keyword.txt. Also, we'd love to see the new features demo'd in an example. These functions may fit best into a pre-existing example so please check.

@balamuruganky
Copy link
Contributor Author

@nseidle : Thanks for your comments! I will add new functions in keywords.txt and write demo for newly added functions.

@PaulZC
Copy link
Collaborator

PaulZC commented Nov 4, 2020

Hi @balamuruganky ,
You perhaps don't need to create a whole new example. You could add the accuracy estimates to this example:
https://github.com/sparkfun/SparkFun_Ublox_Arduino_Library/blob/master/examples/Example13_PVT/Example1_AutoPVT/Example1_AutoPVT.ino
Best wishes,
Paul

@PaulZC
Copy link
Collaborator

PaulZC commented Nov 4, 2020

Hi @balamuruganky ,
In keywords.txt, can you please use a TAB character (not a space) to separate the function from the KEYWORD2?
Thanks!
Paul

@balamuruganky
Copy link
Contributor Author

@PaulZC : Sure. I will change accordingly.

@balamuruganky
Copy link
Contributor Author

@nseidle, @PaulZC : Please review the changes and let me know, if you have any comments. Thanks much for your time.

@PaulZC
Copy link
Collaborator

PaulZC commented Nov 4, 2020

Thank you @balamuruganky ,
I'm merging this into the release_candidate branch. We will test it and then hopefully merge into the master branch in a few days.
Very best wishes,
Paul

@PaulZC PaulZC merged commit eca9868 into sparkfun:release_candidate Nov 4, 2020
@balamuruganky balamuruganky deleted the release_candidate branch November 16, 2020 20:36
@balamuruganky balamuruganky restored the release_candidate branch November 16, 2020 20:37
@balamuruganky balamuruganky deleted the release_candidate branch November 16, 2020 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants