This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Query module regardless of interface type to prove isConnected() #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greatly increases confidence over I2C comm that we are talking to a ublox module.
|
Hrmm, sorry about the other white space fix noise. VSC can get a little squirrelly. |
|
@PaulZC - Please have a look and merge at your discretion. |
|
I think the only issue with this is that if the module is hammering the I2C buffer with auto-PVT messages then sendCommand might fail. Whereas a simple beginTransmission+endTransmission will always succeed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly increases confidence over I2C comm that we are talking to a ublox module. This was already available for Serial (thank you @PaulZC!) but extends it for I2C (and theoretically for SPI someday).
This was needed for auto-detection routines for OpenLog Artemis. We need more than just ack's to verify a thing is what we think it is at address 0x42.