Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

add func getModuleInfo and example #103

Closed
wants to merge 1 commit into from

Conversation

mayopan
Copy link

@mayopan mayopan commented May 4, 2020

There is already a useful function "getProtocolVersion".
But it shows just protocol version number.
So I made a new function getModuleInfo.
It pulls not only versions but also extension information as strings like below.
I made this before to the branch from the library ver 1.7.0, but it has unstable communication around sendCommand and ACK NACK.
But it's fixed in the latest version(later than 1.8.0).
Thanks sparkfun and communities.

Module Info :
Soft version: EXT CORE 3.01 (107900)
Hard version: 00080000
Extensions:
ROM BASE 3.01 (107888)
FWVER=SPG 3.01
PROTVER=18.00
MOD=NEO-M8N-0
FIS=0xEF4015 (100111)
GPS;GLO;GAL;BDS
SBAS;IMES;QZSS

@PaulZC
Copy link
Collaborator

PaulZC commented May 5, 2020

Hi @mayopan ,
Thank you for submitting this PR.
Unfortunately we cannot merge it as it increases the amount of RAM required by the library. The library already requires a lot of RAM and if we allocate more then it will cause problems on platforms like the ATmega328P (which is still very popular).
The only way forward is if you re-write this as an example which uses a custom command. Please see the new Example 20 for details. You will need to add a warning in the code that it may require more RAM than the ATmega328P can provide.
Best wishes,
Paul

@PaulZC PaulZC closed this May 5, 2020
@PaulZC
Copy link
Collaborator

PaulZC commented May 5, 2020

You can define your own MAX_PAYLOAD_SIZE by including (e.g.):
#define MAX_PAYLOAD_SIZE 384
before the
#include "SparkFun_Ublox_Arduino_Library.h"
Best wishes,
Paul

@mayopan
Copy link
Author

mayopan commented May 5, 2020

Hi @PaulZC,
thank you for your quick reply.

Yes, I made some modification to the payload size on the LAST PR for the issue that is linked above, because it didn't work correctly without it.
But on this PR for the ver 1.8 library, the new function works correctly with no modification to the payload size.

I understand the memory limitation for the compatibility with the standard ATmega328 things, and I've not checked this PR with it but checked with ESP32 (that has plenty of memory).

So I'll check this with arduino nano (ATmega328P), and see the example 20.
I'll post the result later.

Best wishes,
mayopan

This was referenced May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants