You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
//payloadCfg is now loaded with current bytes. Get what we need
uint16_t measurementRate {extractInt(0)}; //Pull from payloadCfg at measRate LSB
measurementRate = 1000 / measurementRate; //This may return an int when it's a float, but I'd rather not return 4 bytes
return (measurementRate);
}
The text was updated successfully, but these errors were encountered:
Hi @rubienr ,
I think the original code is OK? It creates measurementRate, sets it to zero and then loads it with the 0'th byte of payloadCfg using extractInt.
Please check.
Best wishes,
Paul
The code is okay. Clang claims that the initialization value 0 is never used but then is overwritten in L 2316 with assignment of extractInt(0). The measurementRate initialization could go from L 2313 to L 2316 as uint16_t measurementRate {extractInt(0)}; and clang would be happy again. I don't want to be picky, but I would like to compile with -Wall -Werror :)
Hi @rubienr ,
OK. However I fear that life is really much too short to make every piece of code 100% clang-compatible! Especially retrospectively...
Let me know if this commit fixes it.
Best wishes,
Paul
Vale is never used:
SparkFun_Ublox_Arduino_Library/src/SparkFun_Ublox_Arduino_Library.cpp
Line 2313 in 97bd455
Suggested fix:
The text was updated successfully, but these errors were encountered: