Skip to content

Adding object oriented syntactical sugar #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2023
Merged

Adding object oriented syntactical sugar #13

merged 2 commits into from
Nov 8, 2023

Conversation

PaulZC
Copy link
Contributor

@PaulZC PaulZC commented Nov 8, 2023

No description provided.

@PaulZC PaulZC requested a review from gigapod November 8, 2023 13:04
@PaulZC
Copy link
Contributor Author

PaulZC commented Nov 8, 2023

Adding that object oriented syntactical sugar you requested...! ;-)

It works nicely. And is much more elegant. But I don't quite understand why the calls to setViewport etc. have to be made through this->QwGrSSD1306:: for it to work. If I remove those, it stops working - the settings are all written out as zeros. The other QwOLED classes work without this... Puzzling!

@gigapod
Copy link
Member

gigapod commented Nov 8, 2023

Looks good. I'm also not sure why you have to use this-> in your subclass, but it's probably some odd c++ behavior that is super important to someone :)

@gigapod gigapod merged commit 206a98e into main Nov 8, 2023
@gigapod gigapod deleted the Add_QwiicCustomOLED branch November 8, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigapod gigapod gigapod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulZC @gigapod