Skip to content

Example 7 variable type mis-match #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
biomurph opened this issue May 25, 2022 · 2 comments
Closed

Example 7 variable type mis-match #45

biomurph opened this issue May 25, 2022 · 2 comments

Comments

@biomurph
Copy link

This is a simple and quite unintelligent bug.
It's just hanging out there right in the middle of everything... so obvious... line 50

byte sampleRate = 400; //Options: 50, 100, 200, 400, 800, 1000, 1600, 3200

But a byte only counts to 255 and then rolls over to 0.
So any sample rate over 200 would be...

Gotta say, I was pulling my hair out with the o'scope on the bench and everything.
The .setup() receives an int in the sampleRate space. Easy fix.

nseidle added a commit that referenced this issue May 25, 2022
@nseidle
Copy link
Member

nseidle commented May 25, 2022

Thanks @biomurph! Fixed.

@nseidle nseidle closed this as completed May 25, 2022
@biomurph
Copy link
Author

smiley face

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants