Skip to content

available() should use signed integer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WayneKeenan opened this issue Mar 28, 2018 · 2 comments
Closed

available() should use signed integer #12

WayneKeenan opened this issue Mar 28, 2018 · 2 comments

Comments

@WayneKeenan
Copy link
Contributor

The uint8_t on the line below should be an int8_t otherwise the comparison after is never true and it has a side effect of the client processing bogus readings.

https://github.com/sparkfun/SparkFun_MAX3010x_Sensor_Library/blob/master/src/MAX30105.cpp#L528
@nseidle
Copy link
Member

nseidle commented Mar 28, 2018

You are very right! Thank you.

@nseidle
Copy link
Member

nseidle commented Mar 28, 2018

Will be fixed in the latest release.

@nseidle nseidle closed this as completed Mar 28, 2018
nseidle added a commit that referenced this issue Mar 28, 2018
@nseidle
Merge pull request #13 from WayneKeenan/master
df86e1e 
Fix for issue #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nseidle @WayneKeenan