Skip to content

Terminate if sensor is not BMP or BME #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SparkFunBME280.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ uint8_t BME280::begin()
}

//Check communication with IC before anything else
uint8_t chipID = readRegister(BME280_CHIP_ID_REG); //Should return 0x60
if(chipID != 0x58) // This is not BMP
if(chipID != 0x60) // This is not BME
uint8_t chipID = readRegister(BME280_CHIP_ID_REG); //Should return 0x60 or 0x58
if(chipID != 0x58 && chipID != 0x60) // Is this BMP or BME?
return(chipID); //This is not BMP nor BME!

//Reading all compensation data, range 0x88:A1, 0xE1:E7
calibration.dig_T1 = ((uint16_t)((readRegister(BME280_DIG_T1_MSB_REG) << 8) + readRegister(BME280_DIG_T1_LSB_REG)));
Expand Down