-
Notifications
You must be signed in to change notification settings - Fork 49
diff: support renamed, updated binary file #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 29.48% 27.24% -2.25%
==========================================
Files 5 5
Lines 1177 1138 -39
==========================================
- Hits 347 310 -37
Misses 784 784
+ Partials 46 44 -2
Continue to review full report at Codecov.
|
Thanks for the PR! I am not the best to review this code but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But, as @unknwon pointed out, please remove the .DS_Store
file from the diff 🙂
@stephen ping :) |
9001611
to
94f220e
Compare
This commit parses a diff with a renamed, updated binary file and adds a test case for it.
Thanks for the reminder. I removed the .DS_Store and rebased to fix conflicts. I tried to match the changes in f935979 in my new diff. |
Separately, adding |
Thanks! |
This commit parses a diff with a renamed, updated binary file and adds a test case for it.
This commit parses a diff with a renamed, updated binary file and adds a test case for it.