Remove unnecessary writer param #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
approved these changes
May 3, 2021
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* chore: fix issues with */ in doc block breaking code gen * chore: remove importexport service because of deprecation * fix(service-types-generator): fix self reference in generated model * fix(service-model): code gen of different models with casing difference * fix: remove universal client generation when import models Currently generated clients' config doesn't compatible with either browser dependency or node dependency because the default streamType is 'Uint8Array', which is not compatible with `Blob` or `Readable` * fix(service-types-generator): remove versions from cloudfront commands * fix: fix incorrect codegen in commands signing middleware * fix: fix naming conflict between operations and shapes * feat: introduce typescript incremental build * chore: add travis wait time for long-running steps
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* chore: fix issues with */ in doc block breaking code gen * chore: remove importexport service because of deprecation * fix(service-types-generator): fix self reference in generated model * fix(service-model): code gen of different models with casing difference * fix: remove universal client generation when import models Currently generated clients' config doesn't compatible with either browser dependency or node dependency because the default streamType is 'Uint8Array', which is not compatible with `Blob` or `Readable` * fix(service-types-generator): remove versions from cloudfront commands * fix: fix incorrect codegen in commands signing middleware * fix: fix naming conflict between operations and shapes * feat: introduce typescript incremental build * chore: add travis wait time for long-running steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.