feat: codegen for waitUntil[State] #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Apr 23, 2021
...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java
Outdated
Show resolved
Hide resolved
trivikr
reviewed
Apr 23, 2021
...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java
Show resolved
Hide resolved
…/typescript/codegen/WaiterGenerator.java Co-authored-by: Trivikram Kamat <[email protected]>
...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java
Outdated
Show resolved
Hide resolved
trivikr
requested changes
Apr 29, 2021
...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java
Outdated
Show resolved
Hide resolved
trivikr
requested changes
Apr 29, 2021
...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java
Outdated
Show resolved
Hide resolved
trivikr
reviewed
May 3, 2021
| writer.writeDocs(waiter.getDocumentation().orElse("") + " \n" | ||
| + " @param params : Waiter configuration options.\n" | ||
| + " @param input : the input to " + operationSymbol.getName() + " for polling."); | ||
| + " @deprecated In favor of waitUntil" + waiterName + ". This does not throw on failure.\n" |
There was a problem hiding this comment.
Suggested change
| + " @deprecated In favor of waitUntil" + waiterName + ". This does not throw on failure.\n" | |
| + " @deprecated Use `waitUntil" + waiterName + "` instead." | |
| + " The `waitFor" + waiterName + "` does not throw error in non-success cases.\n" |
| writer.addImport("WaiterConfiguration", "WaiterConfiguration", WAITABLE_UTIL_PACKAGE); | ||
|
|
||
| // generates the now deprecated WaitFor.... | ||
| writer.writeDocs(waiter.getDocumentation().orElse("") + " \n" |
There was a problem hiding this comment.
Remove waiter documentation, as waitFor is deprecated. Users should read documentation for waitUntil instead.
Suggested change
| writer.writeDocs(waiter.getDocumentation().orElse("") + " \n" | |
| writer.writeDocs( |
AllanZhengYP
approved these changes
May 5, 2021
trivikr
approved these changes
May 7, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* feat: creating codegen for WaitUntilState * fix: spacing * Update smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/WaiterGenerator.java Co-authored-by: Trivikram Kamat <[email protected]> * feat: throw a new error object * fix: minor updates * fix: param annotation in doc generator * fix: capitalization * fix: remove old documentation * fix: documentation spacing Co-authored-by: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Code generation for: aws/aws-sdk-js-v3#2302
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.