Make CompressionInputConfig properties optional #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
approved these changes
Jan 4, 2024
syall
approved these changes
Jan 4, 2024
Comment on lines
-8
to
13
| export const resolveCompressionConfig = <T>(input: T & CompressionInputConfig): T & CompressionResolvedConfig => ({ | ||
| export const resolveCompressionConfig = <T>( | ||
| input: T & Required<CompressionInputConfig> | ||
| ): T & CompressionResolvedConfig => ({ | ||
| ...input, | ||
| disableRequestCompression: normalizeProvider(input.disableRequestCompression), | ||
| requestMinCompressionSizeBytes: async () => { |
There was a problem hiding this comment.
nit: is it safer to guard against undefined values for disableRequestCompression and requestMinCompressionSizeBytes, and not make CompressionInputConfig required?
There was a problem hiding this comment.
There won't be undefined values when calling resolveCompressionConfig as runtimeConfig resolution ensure that it's defined. If it doesn't, the client compilation should fail like it's happening in protocol tests.
Also, the Required doesn't allow undefined.
Playground Link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Refs: aws/aws-sdk-js-v3#5643 (comment)
Description of changes:
Make CompressionInputConfig properties optional
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.