Skip to content

Proxy config secure flag #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tomtucker18
Copy link

Adds new option secure to the config. Allows HTTPS requests to self-signed certificates.
The secure flag is set to true if it isn't configured. In that way the behavior stays the same as it was before this change.

Closes Issue #54

@simonh1000 simonh1000 self-requested a review January 13, 2023 09:16
@simonh1000
Copy link
Owner

Thanks very much

I have very little time and will need to find a way to test this, which will mean there will be a delay in reviewing. Hopefully in the next few weeks

@Hypercubed
Copy link

@simonh1000 I could really use this... anyway we can help you test?

@simonh1000
Copy link
Owner

This looks good to me. What do you think @AVierwind ?
@tomtucker18 - could you merge master into your PR?

Copy link
Owner

@simonh1000 simonh1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also want @AVierwind's view

@AVierwind
Copy link
Contributor

Seems good to me!

Copy link
Owner

@simonh1000 simonh1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind. Let's just have a config option proxy (i.e. no CLI option) that we just pass directly to proxyServer - we don't need to handle individual options and can let the user set anything they want from the features of the proxy library

@tomtucker18
Copy link
Author

@simonh1000 I've implemented your proposed change. Now the whole proxy config object is used on proxy creation. However, I left the format of the existing properties (forward, target, protocol) as they are in order to maintain backward compatibility.

@tomtucker18
Copy link
Author

Hi @simonh1000,

I wanted to check in and see if you've had a chance to review my changes. If there's anything else I need to add, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants