Skip to content

Add Connection Pooling #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Add Connection Pooling #5

merged 2 commits into from
Mar 20, 2018

Conversation

billwashere
Copy link
Contributor

This commit adds Connection Pooling as well as the ability to pass database details via environment arguments.

Added some semicolons, also PostgresDB.pg_config no longer needs to be saved
@nornagon
Copy link
Member

Awesome, thanks for separating this out! I pulled it down locally to do some testing and it looks like the old style of passing a database URL a la postgres://$HOST:$PORT/$DB_NAME is no longer supported in pg. That's a breaking change, so we should document it in a changelog (that doesn't yet exist) and bump the major version.

@nornagon nornagon merged commit 3ae70bf into share:master Mar 20, 2018
@billwashere
Copy link
Contributor Author

You should be able to pass in the connection string by going

{
  connectionString:"postgres://$HOST:$PORT/$DB_NAME"
} We

Instead of host and port

@nornagon
Copy link
Member

(...belatedly), i've published v3.0.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants