Roll Heroku breaking changes in #426 back to #416 #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in commit #421, pushing to Heroku failed with an asset compilation error as described in issue #429.
This PR fixes pushing to Heroku by rolling back Yarn to version 0.22.0 and precisely specifying a LTS node version (8.9.3). Using node 7.8.0 gave warnings about bugs and unstable performance and was not a long-term support version. Inadvertently using node versions other than 8.9.3 also produced other errors when pushing to Heroku (ranges were specified in the package.json engines section).
All other gems and node packages were advanced to the latest versions, with the exceptions of those which were locked back to avoid breaking changes.
All tests are green, all linting is green, ActionCable is working, and there are only one or two deprecation warnings which still need fixing.
This change is