Skip to content

Fix eslint plugin error #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix eslint plugin error #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client/app/stores/commentsStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ import reducers from '../reducers';
import { initalStates } from '../reducers';

export default props => {
const initialComments = props;
const { $$commentsState } = initalStates;
const initialState = {
$$commentsStore: $$commentsState.merge({
$$comments: initialComments,
$$comments: props,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bizarre.

  1. Please back out this change. The old code is important for readability.
  2. we should ignore the eslint rule here and with a comment to the github issue indicating the problem.
  3. please put a link to this code in the eslint issue (actually react-plugin probably, not main eslint)

Thanks @josiasds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josiasds @justin808 Maybe you can just disable the rule for only this file or block? and not for the whole app. Don't know if the plugin will allow this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylangrafmyre yep, we just need to put /* eslint react/prop-types: 0 */ at the top of the file or wrapping the whole block, see bc07695.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 Done 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}),
};

Expand Down