Skip to content

setting node version on travis #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2015
Merged

setting node version on travis #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89e6db
setting node version on travis
marcusvmsa Dec 2, 2015
bea74ab
installing node before use on travis
marcusvmsa Dec 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ rvm:
- 2.2.3
install:
- bundle install
- nvm install 5.0
- nvm use 5.0
- npm install -g npm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 @MaMute Since we are now installing Node 5.0 with nvm, we can probably remove npm install -g npm. Node 5.0 comes with NPM 3.x.x.

Before travis was using a older version of npm that was failing our build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dylangrafmyre I just merged. Let's do another PR if that's the case.

BTW, I get the linting error locally, so this is probably not the main build issue. There's some problem with eslint?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 the main build failure is from a c++ compiler error for NAN module used in sleep. I will fix this. This only for the travis build. The Codeship build fails with the eslint error.

- npm install
- cd client && npm run build:client
Expand Down