tokenizer: Look for both env() and var() functions. #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some objections to the way this features is specified to work, but they are for CSSWG rather than this repo. In the meantime, let’s not block Firefox compat with what’s already shipping elsewhere. @bors-servo r+ |
|
📌 Commit 6adba1b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2018
tokenizer: Look for both env() and var() functions. Differential Revision: https://phabricator.services.mozilla.com/D9609 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/230) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo r=SimonSapin,heycam |
|
📌 Commit 7f0461a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2018
tokenizer: Look for both env() and var() functions. Differential Revision: https://phabricator.services.mozilla.com/D9609 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/230) <!-- Reviewable:end -->
|
(since cam took a look upstream) |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D9609
This change is