Skip to content

Fix according to other codes #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Fix according to other codes #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f7cccc
Modify to strict comparison with other codes
abetomo Nov 1, 2017
fdf16f1
Remove unnecessary else
abetomo Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/pip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,12 @@ function installRequirements() {
if (res.error.code === 'ENOENT') {
if (this.options.dockerizePip) {
throw new Error('docker not found! Please install it.');
} else {
throw new Error(`${this.options.pythonBin} not found! Try the pythonBin option.`);
}
throw new Error(`${this.options.pythonBin} not found! Try the pythonBin option.`);
}
throw new Error(res.error);
}
if (res.status != 0)
if (res.status !== 0)
throw new Error(res.stderr);
};

Expand Down
2 changes: 1 addition & 1 deletion lib/pipenv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function pipfileToRequirements() {
throw new Error(`pipenv not found! Install it with 'pip install pipenv'.`);
throw new Error(res.error);
}
if (res.status != 0)
if (res.status !== 0)
throw new Error(res.stderr);
fse.ensureDirSync(path.join(this.servicePath, '.serverless'));
fse.writeFileSync(path.join(this.servicePath, '.serverless/requirements.txt'), res.stdout);
Expand Down